Draft
Conversation
Contributor
Review Summary by QodoAdd template LLM configuration support with inheritance
WalkthroughsDescription• Add template LLM configuration support with response format settings • Implement agent template detail retrieval with LLM config inheritance • Use template-specific LLM config in instruct mode execution • Refactor template config loading and persistence in file repository Diagramflowchart LR
A["Agent Template"] -->|"inherits from"| B["AgentTemplateConfig"]
B -->|"contains"| C["LlmConfig"]
C -->|"extends"| D["LlmConfigBase"]
E["InstructService"] -->|"retrieves"| F["Template Detail"]
F -->|"uses LLM config"| G["Chat Completion"]
H["FileRepository"] -->|"loads/saves"| I["template_configs.json"]
I -->|"provides"| C
File Changes1. src/Infrastructure/BotSharp.Abstraction/Agents/IAgentService.cs
|
Contributor
Code Review by Qodo
1. Template override drops settings
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+746
to
+750
| var fileName = file.Split(Path.DirectorySeparatorChar).Last(); | ||
| var splitIdx = fileName.LastIndexOf("."); | ||
| var name = fileName.Substring(0, splitIdx); | ||
| var extension = fileName.Substring(splitIdx + 1); | ||
| if (name.IsEqualTo(templateName) && extension.IsEqualTo(_agentSettings.TemplateFormat)) |
Contributor
There was a problem hiding this comment.
1. No guard for splitidx 📘 Rule violation ☼ Reliability
GetAgentTemplateDetail uses LastIndexOf(".") and then calls Substring without guarding for
-1, which can throw at the storage boundary when files don't match the expected naming format.
This violates the requirement to add explicit null/empty/invalid guards at provider boundaries and
return safe fallbacks.
Agent Prompt
## Issue description
Filename parsing assumes every file name contains a `.` and uses `Substring` with an unchecked index, which can throw and break reads at the repository boundary.
## Issue Context
This code runs against files in a directory and must tolerate unexpected/invalid file names.
## Fix Focus Areas
- src/Infrastructure/BotSharp.Core/Repository/FileRepository/FileRepository.Agent.cs[746-750]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| { | ||
| var template = agent?.Templates?.FirstOrDefault(x => x.Name == options.TemplateName)?.Content ?? string.Empty; | ||
| instruction = BuildInstruction(template, options?.Data ?? []); | ||
| var template = agent?.Templates?.FirstOrDefault(x => x.Name == options.TemplateName); |
Contributor
There was a problem hiding this comment.
2. Case-sensitive templatename match 📘 Rule violation ≡ Correctness
Template selection compares identifier-like names with ==, which is case-sensitive and can behave inconsistently for identifier matching. This violates the requirement to use ordinal, case-insensitive comparisons for identifiers.
Agent Prompt
## Issue description
Template lookup uses a case-sensitive equality operator for an identifier-like string (`TemplateName`), risking mismatches.
## Issue Context
Identifier comparisons must be culture-invariant and case-insensitive.
## Fix Focus Areas
- src/Infrastructure/BotSharp.Core/Instructs/Services/InstructService.Instruct.cs[69-69]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
574
to
576
| public async Task<bool> PatchAgentTemplate(string agentId, AgentTemplate template) | ||
| { | ||
| if (string.IsNullOrEmpty(agentId) || template == null) |
Contributor
There was a problem hiding this comment.
3. Mongo patch drops config 🐞 Bug ≡ Correctness
MongoRepository.PatchAgentTemplate updates only Content, so template ResponseFormat/LlmConfig
changes sent via /agent/{agentId}/templates are silently lost when Mongo storage is used.
Agent Prompt
### Issue description
MongoRepository.PatchAgentTemplate persists only `Content`, dropping new per-template fields (`ResponseFormat`, `LlmConfig`) when templates are patched.
### Issue Context
`/agent/{agentId}/templates` uses `AgentTemplate` as request payload, so clients can submit `responseFormat`/`llmConfig` but Mongo storage will ignore them.
### Fix Focus Areas
- src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Agent.cs[574-597]
### Implementation notes
Update the found template element to include:
- `foundTemplate.ResponseFormat = template.ResponseFormat;`
- `foundTemplate.LlmConfig = AgentTemplateLlmConfigMongoModel.ToMongoModel(template.LlmConfig);`
(or replace the element in the list with `AgentTemplateMongoElement.ToMongoElement(template)`), then persist the updated templates array.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
yileicn
reviewed
Apr 14, 2026
| MaxOutputTokens = agent.LlmConfig.MaxOutputTokens, | ||
| ReasoningEffortLevel = agent.LlmConfig.ReasoningEffortLevel | ||
| }; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Response format is included in the template detail. It is outside the llm config
added 4 commits
April 14, 2026 11:16
…atures/refine-template-config
Member
|
/review |
Contributor
|
Persistent review updated to latest commit 5375da1 |
Comment on lines
+245
to
+261
| var prompt = string.Empty; | ||
| var llmConfig = agent.LlmConfig; | ||
|
|
||
| if (!string.IsNullOrEmpty(templateName)) | ||
| { | ||
| prompt = agentService.RenderTemplate(agent, templateName); | ||
| var templateLlmConfig = agent.Templates?.FirstOrDefault(x => x.Name.IsEqualTo(templateName))?.LlmConfig; | ||
| if (templateLlmConfig?.IsValid == true) | ||
| { | ||
| llmConfig = new AgentLlmConfig | ||
| { | ||
| Provider = templateLlmConfig.Provider, | ||
| Model = templateLlmConfig.Model, | ||
| MaxOutputTokens = templateLlmConfig.MaxOutputTokens, | ||
| ReasoningEffortLevel = templateLlmConfig.ReasoningEffortLevel | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
1. Template override drops settings 🐞 Bug ≡ Correctness
When a template has a valid LlmConfig, InstructService replaces agent.LlmConfig with a new AgentLlmConfig that only copies Provider/Model/MaxOutputTokens/ReasoningEffortLevel, resetting other AgentLlmConfig fields to defaults for that run. This can change behavior (e.g., recursion depth or modality configs) whenever template overrides are used.
Agent Prompt
### Issue description
When template LLM overrides apply, the code constructs a new `AgentLlmConfig` with only a subset of properties, which resets other agent-level settings (e.g. recursion depth and other modality configs).
### Issue Context
Template LLM config should override only the fields it intends to change while preserving the rest of the agent’s effective LLM configuration.
### Fix
- In both places where a template-level LLM config is applied, start from the existing agent config (clone/copy) and override only the specific fields from the template.
- Ensure fields like `IsInherit`, `MaxRecursionDepth`, and any nested configs remain unchanged unless explicitly overridden.
### Fix Focus Areas
- src/Infrastructure/BotSharp.Core/Instructs/Services/InstructService.Execute.cs[244-270]
- src/Infrastructure/BotSharp.Core/Instructs/Services/InstructService.Instruct.cs[56-91]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.